Avoid inserting grouping commas into large numbers #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzbrooks
force-pushed
the
remove-digit-grouping
branch
from
960fb60 to
64b597f
Compare
jzbrooks
force-pushed
the
remove-digit-grouping
branch
from
64b597f to
cca07e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.
The problem was obvious after isolating the command where the paths diverged.
The issue wasn't obvious because differences of relative command coordinates usually aren't big, but the radius of an arc is a magnitude, so it isn't relative to anything. This seemed like a bug with the convert curves to arc optimization because it is the most likely place for this command printing bug to have surfaced. Not only that, but the optimization also needs to select the arc with a huge radius over the bezier curve, which makes surfacing this bug even less likely.