[Feat] Firebase image 업로드 할 수 있도록 컴포넌트와 훅 추가 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoripong
reviewed
Sep 18, 2021
YuuRiLee
force-pushed
the
design-input-change
branch
from
1e9d9fd
to
4e004ae
Compare
YuuRiLee
force-pushed
the
firebase-image
branch
from
d563ff4
to
a5389d7
Compare
zoripong
reviewed
Oct 10, 2021
src/hooks/useFirebaseStorage.ts
Outdated
| @@ -28,11 +27,9 @@ type FirebaseStorage = Omit<UploadStorage, 'error'> & { | |||
| }; | |||
|
|
|||
| const useFirebaseStorage = (path: string): FirebaseStorage => { | |||
| const history = useHistory(); | |||
| const token = getAccessToken(); | |||
|
|
|||
| if (token == null) { | |||
There was a problem hiding this comment.
p3: 이 체크를 아예 안해도 되지 않을까요? 이제 여기가 true가 될 일이 없을 것 같은뎅 👀
There was a problem hiding this comment.
음 타입스크립트가 문제라서유,, 그냥 빈 문자열로 리턴해줘야겠네유
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 빈문자열이 더 싫은데... undefined 반환은 어떠신가요
There was a problem hiding this comment.
undefined로 리턴하면 지금처럼 if (token == null) 이렇게 체크해줘야해욤,,
There was a problem hiding this comment.
그냥 체크하기로 합시댜....... ㅠ_ㅠ
리턴타입에 void 섞여있어서 그런거죠?
There was a problem hiding this comment.
redirectToLogin 리턴 타입을 void로 해서 그래용 undefined로 바꿔도 마찬가지기는 합니드앙
|
@jiyaaany 나중에 여기 커밋들 확인해주세용 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 제안 사유
Resolve #102
주요 변경 기록
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷
기타 질문 및 특이 사항