-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Firebase image 업로드 할 수 있도록 컴포넌트와 훅 추가 #107
Conversation
1e9d9fd
to
4e004ae
Compare
d563ff4
to
a5389d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 몇개만 더..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어푸르브 아니고 코멘트..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saso 한 하나만 찐 막으로 확인해쥬세용
src/hooks/useFirebaseStorage.ts
Outdated
@@ -28,11 +27,9 @@ type FirebaseStorage = Omit<UploadStorage, 'error'> & { | |||
}; | |||
|
|||
const useFirebaseStorage = (path: string): FirebaseStorage => { | |||
const history = useHistory(); | |||
const token = getAccessToken(); | |||
|
|||
if (token == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: 이 체크를 아예 안해도 되지 않을까요? 이제 여기가 true가 될 일이 없을 것 같은뎅 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 타입스크립트가 문제라서유,, 그냥 빈 문자열로 리턴해줘야겠네유
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 안돼....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 빈문자열이 더 싫은데... undefined 반환은 어떠신가요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined로 리턴하면 지금처럼 if (token == null)
이렇게 체크해줘야해욤,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 체크하기로 합시댜....... ㅠ_ㅠ
리턴타입에 void 섞여있어서 그런거죠?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redirectToLogin 리턴 타입을 void로 해서 그래용 undefined로 바꿔도 마찬가지기는 합니드앙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅅㅜㄱㅗ하셨습니당
@jiyaaany 나중에 여기 커밋들 확인해주세용 |
PR 제안 사유
Resolve #102
주요 변경 기록
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷
기타 질문 및 특이 사항