-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 판매할 도안 리스트 컴포넌트 추가 #121
Conversation
rebase 커밋은 무어신가요 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타로 추정되는 변수명 하나만 고쳐주세요..! 아니면 진짜 roadMore인가..?
return ( | ||
<StyledList> | ||
<InfiniteScroll | ||
dataLength={designs.length} | ||
next={getNextDesigns} | ||
next={roadMore} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3: roadMore..? ㅋㅋㅋ loadMore를 의도한거죠..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아앗,,,, 바꿀게요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3ad1ef9 봐주세유
제가 한 커밋은 아니에유 |
커미터가 이율이라,, 직접한줄 알았어유 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roadMore 이 플러그인에 안잡힌게 신기하네요 ㅋㅋㅋㅋ
그러게유 플러그인아 일 해,, |
8a54f3e
to
d7868b6
Compare
^ 요건 113 머지되면 머지할게요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 작업했던 코드도 들어가있는 것 같은데 커밋 체리픽해서 작업하신건가유 ???
@@ -52,7 +52,7 @@ export const useImageFileUploader = ({ | |||
|
|||
const isInvalidFiles = (files: FileList | null): boolean => { | |||
if (files == null || files.length < 1) { | |||
return false; | |||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머지머지합시다 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#123 머지해주세유,,,, ✨ 👀
아녀 리베이스해서 했우여 |
3ad1ef9
to
e926f41
Compare
^ sprint-2-1 에서 수정한 것들만 체리픽했습니담 |
PR 제안 사유
[키워드] #[이슈번호]
Resolve #120
주요 변경 기록
#119 에서 #113 를 리베이스 했습니다! 따라서 Refactor: 내 도안 리스트와 관련된 코드 커스텀 훅으로 분리 해당 커밋부터 봐주세요!!!!
체크박슬스는 다른 pr에서 작업할 예정입니다
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷