[Feat] 판매할 도안 리스트 컴포넌트 추가 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase 커밋은 무어신가요 👀 |
zoripong
reviewed
Oct 20, 2021
| return ( | ||
| <StyledList> | ||
| <InfiniteScroll | ||
| dataLength={designs.length} | ||
| next={getNextDesigns} | ||
| next={roadMore} |
There was a problem hiding this comment.
p3: roadMore..? ㅋㅋㅋ loadMore를 의도한거죠..?
제가 한 커밋은 아니에유 |
커미터가 이율이라,, 직접한줄 알았어유 |
zoripong
approved these changes
Oct 23, 2021
그러게유 플러그인아 일 해,, |
YuuRiLee
force-pushed
the
create-design-post-edit
branch
from
8a54f3e
to
d7868b6
Compare
|
^ 요건 113 머지되면 머지할게요 |
jiyaaany
approved these changes
Oct 25, 2021
jiyaaany
reviewed
Oct 27, 2021
| @@ -52,7 +52,7 @@ export const useImageFileUploader = ({ | |||
|
|
|||
| const isInvalidFiles = (files: FileList | null): boolean => { | |||
| if (files == null || files.length < 1) { | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
#123 머지해주세유,,,, ✨ 👀
아녀 리베이스해서 했우여 |
YuuRiLee
force-pushed
the
select-designs
branch
from
3ad1ef9
to
e926f41
Compare
|
^ sprint-2-1 에서 수정한 것들만 체리픽했습니담 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 제안 사유
[키워드] #[이슈번호]
Resolve #120
주요 변경 기록
#119 에서 #113 를 리베이스 했습니다! 따라서 Refactor: 내 도안 리스트와 관련된 코드 커스텀 훅으로 분리 해당 커밋부터 봐주세요!!!!
체크박슬스는 다른 pr에서 작업할 예정입니다
Code review
Code review 에서 중점적으로 봐야하는 부분
Design review
Design review 에서 중점적으로 봐야하는 부분 / 스크린샷