Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 판매할 도안 리스트 체크박스 추가 #128

Merged
merged 5 commits into from
Nov 18, 2021
Merged

[Feat] 판매할 도안 리스트 체크박스 추가 #128

merged 5 commits into from
Nov 18, 2021

Conversation

YuuRiLee
Copy link
Contributor

PR 제안 사유

Resolve #122

주요 변경 기록

  • 내 도안 리스트 컴포넌트에 체크 박스로 선택할 수 있도록합니다
  • DesignItem 스타일 관련 코드들을 분리합니다

Code review

Code review 에서 중점적으로 봐야하는 부분

Design review

Design review 에서 중점적으로 봐야하는 부분 / 스크린샷

스크린샷 2021-10-30 오전 12 09 55

기타 질문 및 특이 사항

@YuuRiLee YuuRiLee added Feat 새로운 기능과 관련된 작업 Design 디자인과 관련된 작업 labels Oct 29, 2021
@YuuRiLee YuuRiLee self-assigned this Oct 29, 2021
Base automatically changed from select-designs to sprint-2-1 November 5, 2021 14:28
@YuuRiLee
Copy link
Contributor Author

@jiyaaany 해당 커밋 부터 봐주세요

jiyaaany
jiyaaany approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@jiyaaany jiyaaany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@YuuRiLee YuuRiLee merged commit bb2d8f1 into sprint-2-1 Nov 18, 2021
@YuuRiLee YuuRiLee deleted the select-design-handle branch November 18, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyaaany jiyaaany jiyaaany approved these changes

@zoripong zoripong Awaiting requested review from zoripong

Assignees

@YuuRiLee YuuRiLee

Labels
Design 디자인과 관련된 작업 Feat 새로운 기능과 관련된 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuuRiLee @jiyaaany