Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 도안 작성 페이지 (개요 하단 부분) #131

Merged
merged 9 commits into from
Nov 26, 2021

Conversation

YuuRiLee
Copy link
Contributor

@YuuRiLee YuuRiLee commented Nov 5, 2021

PR 제안 사유

Resolve #130

주요 변경 기록

  • RequiredInput을 좀 더 범용적으로 쓸 수 있도록 InputWithLabel로 변경합니다
  • 도안 개요 입력하기 - 부가정보 input들을 추가합니다

Code review

Code review 에서 중점적으로 봐야하는 부분

Design review

Design review 에서 중점적으로 봐야하는 부분 / 스크린샷

스크린샷 2021-11-06 오전 2 04 02

기타 질문 및 특이 사항

@YuuRiLee YuuRiLee added Feat 새로운 기능과 관련된 작업 Design 디자인과 관련된 작업 Refactor 코드를 개선한 작업 labels Nov 5, 2021
@YuuRiLee YuuRiLee self-assigned this Nov 5, 2021
@@ -12,7 +12,7 @@ import {
Typography,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: CreateDesign/Detail 페이지는 도안 작성 단계가 분리되기 전에 한꺼번에 입력하는 페이지인데, 없어져도 무방한 페이지인가요 ???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇죵 다른 pr에서 지울게유

Copy link
Contributor

@jiyaaany jiyaaany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@YuuRiLee YuuRiLee force-pushed the create-design-page-bottom-input branch from 2cd647f to aa7519c Compare November 18, 2021 15:50
@jiyaaany
Copy link
Contributor

jiyaaany commented Nov 22, 2021

@YuuRiLee 이거부터 126으로 머지하고 #129 pr 2-4 브랜치로 머지할까유???

@YuuRiLee
Copy link
Contributor Author

@YuuRiLee 이거부터 126으로 머지하고 #129 pr 2-4 브랜치로 머지할까유???

#129 먼저 2-4로 머지하는게 낫지 않나욤??

Base automatically changed from #126/create-design-page to sprint-2-4 November 23, 2021 03:35
@YuuRiLee YuuRiLee force-pushed the create-design-page-bottom-input branch from aa7519c to 6956c88 Compare November 26, 2021 08:48
@YuuRiLee YuuRiLee merged commit 932571c into sprint-2-4 Nov 26, 2021
@YuuRiLee YuuRiLee deleted the create-design-page-bottom-input branch November 26, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design 디자인과 관련된 작업 Feat 새로운 기능과 관련된 작업 Refactor 코드를 개선한 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants