Fix pollution of includedUnits defaults
#9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 4.0.0 release of enhanced-ms, passing
includeMs: trueto the format method causes subsequent calls to always include milliseconds in the resulting string, even whenincludeMs: falseis specified:The same issue occurs with
includeSubMs: truefor microseconds and nanoseconds.The bug stems from the
resolveFormatOptionsmethod, which modifies the originaldefaultFormatOptions.includedUnitsarray here:https://github.com/apteryxxyz/enhanced-ms/blob/f119aff3969e72524a74139c3efca7081ab91597/src/format/helpers/resolve-options.ts#L133-L134
This PR fixes it by simply creating a copy of said array.