Skip to content

Await Asynchronous Module Imports #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darkobits wants to merge 1 commit into from
Closed

Await Asynchronous Module Imports #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/server/helpers/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,23 @@ export async function importRouteModule(
);
}
} catch {}

// @ts-expect-error - getPageModule is protected
const buildPagePath = nextServer.getPagePath(filePath);
return importModule<RouteModule>(buildPagePath);
const module = await importModule<RouteModule>(buildPagePath);

// Resolve any Promise in the default export. This is needed for Next.js App
// Router where the default export is often a Promise. Without this, attempts
// to access handlers on the unresolved Promise will fail.
if (module?.default instanceof Promise) {
const resolvedDefault = await module.default;
return {
...module,
default: resolvedDefault
};
}

return module;
}

/**
Expand Down
Loading