Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suffix arrays, needed for nbest processing #786

Merged
merged 18 commits into from
Jul 30, 2021
Merged

Suffix arrays, needed for nbest processing #786

merged 18 commits into from
Jul 30, 2021

Conversation

pkufool
Copy link
Collaborator

@pkufool pkufool commented Jul 19, 2021 •
edited
Loading

@pkufool
Copy link
Collaborator Author

pkufool commented Jul 20, 2021

@danpovey What should the mean and variance be when there is no best-matching-position (tightest interval is root interval), zeros?

@danpovey
Copy link
Collaborator

It's OK to use the root interval itself.
If the root interval has zero stats (which should not happen), you can use zeros.

csukuangfj
csukuangfj reviewed Jul 21, 2021
View reviewed changes
k2/csrc/CMakeLists.txt Outdated Show resolved Hide resolved
k2/python/k2/utils.py Outdated Show resolved Hide resolved
@pkufool pkufool mentioned this pull request Jul 23, 2021
Merged
@danpovey danpovey merged commit 10ec192 into k2-fsa:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkufool @danpovey @csukuangfj