Clarify some comments in rm_epsilon; fix possible bug there.#965
Open
danpovey wants to merge 2 commits intok2-fsa:masterfrom
Open
Clarify some comments in rm_epsilon; fix possible bug there.#965danpovey wants to merge 2 commits intok2-fsa:masterfrom
danpovey wants to merge 2 commits intok2-fsa:masterfrom
Conversation
Collaborator
Author
|
RE that change in rm_epsilon.cu: that loop would have looped indefinitely if those 2 arrays were different after the 1st iter. |
Collaborator
Sure. |
danpovey
commented
Apr 25, 2022
| // change in the FsaVec (this can be by simple comparison on arcs vector, | ||
| // since thanks to sorting the order is deterministic). | ||
| Array1<Arc> epsilon_fsa_arcs = epsilon_fsa.values; | ||
| Array1<Arc> &epsilon_fsa_arcs = epsilon_fsa.values; |
Collaborator
Author
There was a problem hiding this comment.
Actually, sorry, I realized this is not the source of the problem, I did not notice the statement below, closure_fsa_arcs = cur_iter_closure_fsa.values;
I will refactor a little for clarity though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.