Use log probs for paraformer #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Apr 9, 2023
sherpa-onnx/csrc/math.h
Outdated
| @@ -103,5 +103,18 @@ std::vector<int32_t> TopkIndex(const T *vec, int32_t size, int32_t topk) { | |||
| return index; | |||
| } | |||
|
|
|||
| template <class T> | |||
There was a problem hiding this comment.
Please follow
sherpa-onnx/sherpa-onnx/csrc/offline-ctc-greedy-search-decoder.cc
Lines 35 to 39 in 80060c2
to use std::max_element to replace ArgMax().
You don't need to reimplement the wheel.
There was a problem hiding this comment.
p_log_probs is const float *, why do we use static_cast again?
There was a problem hiding this comment.
p_log_probsisconst float *, why do we usestatic_castagain?
yes, you are right. please remove the cast.
csukuangfj
reviewed
Apr 9, 2023
Comment on lines
23
to
24
| const float *p = log_probs.GetTensorData<float>(); | ||
| for (int32_t i = 0; i != batch_size; ++i) { |
There was a problem hiding this comment.
Suggested change
| const float *p = log_probs.GetTensorData<float>(); | |
| for (int32_t i = 0; i != batch_size; ++i) { | |
| for (int32_t i = 0; i != batch_size; ++i) { | |
| const float *p = log_probs.GetTensorData<float>() + i * num_tokens * vocab_size; |
|
Thanks! |
XiaYucca
pushed a commit
to XiaYucca/sherpa-onnx
that referenced
this pull request
Jan 9, 2025
* Use log probs for paraformer * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.