-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow more online models to load tokens file from the memory #1352
Conversation
…memory buffers added 2 exmaples respectively
corrected ctc example model url updated CMakefile.txt for testring streaming ctc and paraformer
changed some comment to be more clear
for the keywords spotter example, the kws model failed to spot any keywords among the given test wavs. however, if i record a wav myself, only the @你好军哥 can be spotted, could u help check the keywords-spotter-buffered-tokens-keywords-c-api.c, I can not figure the problem, other than imputing it to the model accuray |
the check "test-nodejs / test-nodejs (ubuntu-latest, 3.8) (pull_request)" failed due to the wasm filesystem, both keywords_file and keywords_buf are provided, which did not pass the validate(). |
Please check the keywords contained in the keywords.txt and check whether the test wave file contains a keyword. |
…nce it's not be used. for the keywords spotter test example, using test_keywords.txt from the test_wavs dir so that keywords can be spotted out.
my mistake, I confused with the test_wavs/test_keywords.txt and the keywords.txt, now the keywords can be spotted out |
Please focus only on the C++ and C APIs. I will fix the errors related to other programming language APIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me. Only left some minor comments.
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
it is ready to merge for me |
Thank you for your contribution! |
for online paraformer and ctc, their symbol tables are able to be initialized from tokens in a memory buffer