Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more online models to load tokens file from the memory #1352

Merged
merged 12 commits into from
Sep 20, 2024

Conversation

shawl336
Copy link
Contributor

for online paraformer and ctc, their symbol tables are able to be initialized from tokens in a memory buffer

xiao added 4 commits September 15, 2024 17:19
…memory buffers

added 2 exmaples respectively
corrected ctc example model url
updated CMakefile.txt for testring streaming ctc and paraformer
@shawl336
Copy link
Contributor Author

for the keywords spotter example, the kws model failed to spot any keywords among the given test wavs. however, if i record a wav myself, only the @你好军哥 can be spotted, could u help check the keywords-spotter-buffered-tokens-keywords-c-api.c, I can not figure the problem, other than imputing it to the model accuray

@shawl336
Copy link
Contributor Author

the check "test-nodejs / test-nodejs (ubuntu-latest, 3.8) (pull_request)" failed due to the wasm filesystem, both keywords_file and keywords_buf are provided, which did not pass the validate().
should i add a special case for wasm in the validate or change the test code for the wasm filesystem (i am not familiar to wasm)

@csukuangfj
Copy link
Collaborator

for the keywords spotter example, the kws model failed to spot any keywords among the given test wavs

Please check the keywords contained in the keywords.txt and check whether the test wave file contains a keyword.

shawl336 and others added 2 commits September 18, 2024 21:56
…nce it's not be used.

for the keywords spotter test example, using test_keywords.txt from the test_wavs dir so that keywords can be spotted out.
@shawl336
Copy link
Contributor Author

for the keywords spotter example, the kws model failed to spot any keywords among the given test wavs

Please check the keywords contained in the keywords.txt and check whether the test wave file contains a keyword.

my mistake, I confused with the test_wavs/test_keywords.txt and the keywords.txt, now the keywords can be spotted out

@csukuangfj
Copy link
Collaborator

the check "test-nodejs / test-nodejs (ubuntu-latest, 3.8) (pull_request)" failed due to the wasm filesystem, both keywords_file and keywords_buf are provided, which did not pass the validate(). should i add a special case for wasm in the validate or change the test code for the wasm filesystem (i am not familiar to wasm)

should i add a special case for wasm in the validate or change the test code for the wasm filesystem

Please focus only on the C++ and C APIs. I will fix the errors related to other programming language APIs.

Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. Only left some minor comments.

.github/workflows/c-api-from-buffer.yaml Outdated Show resolved Hide resolved
.github/workflows/c-api-from-buffer.yaml Outdated Show resolved Hide resolved
.github/workflows/c-api-from-buffer.yaml Outdated Show resolved Hide resolved
.github/workflows/c-api-from-buffer.yaml Outdated Show resolved Hide resolved
.github/workflows/c-api-from-buffer.yaml Outdated Show resolved Hide resolved
@shawl336
Copy link
Contributor Author

it is ready to merge for me

@csukuangfj
Copy link
Collaborator

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 06b61cc into k2-fsa:master Sep 20, 2024
190 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants