fix issue in upload and offlind-record pages of python streaming server #284
+258
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Aug 17, 2023
python-api-examples/http_server.py
Outdated
| @@ -23,17 +23,20 @@ | |||
| ("/js/bootstrap.min.js", "application/javascript"), | |||
| ("/js/bootstrap.min.js.map", "application/javascript"), | |||
| ("/js/jquery-3.6.0.min.js", "application/javascript"), | |||
| ("/js/offline_record.js", "application/javascript"), | |||
| ("/js/offline_record.js", "application/javascript"), | |||
| ("/js/offline_record_streaming.js", "application/javascript"), | |||
There was a problem hiding this comment.
Offline and non-streaming are synonymous.
Please either use offline_record.js or use non_streaming_record.js.
There was a problem hiding this comment.
I think offline record just means we record the voice into one buffer, like a file,
then we still have streaming and non-streaming mode to transcribe the buffer,
streaming mode is to send the buffer bytes in stream and receive the result at the same time,
while non-streaming mode is to send the whole buffer firstly
and then receive the whole result text in one response,
so we should still need two different js files for offline record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue in upload and offlind-record pages of python streaming server