overall: always defer close docker client connections

pkg/runtimes/docker/container.go

@@ -49,6 +49,7 @@ func createContainer(dockerNode *NodeInDocker, name string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// create container
 	var resp container.ContainerCreateCreatedBody
@@ -88,6 +89,7 @@ func removeContainer(ID string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// (1) define remove options
 	options := types.ContainerRemoveOptions{
@@ -141,6 +143,7 @@ func getNodeContainer(node *k3d.Node) (*types.Container, error) {
 		log.Errorln("Failed to create docker client")
 		return nil, err
 	}
+	defer docker.Close()
 
 	// (1) list containers which have the default k3d labels attached
 	filters := filters.NewArgs()

pkg/runtimes/docker/kubeconfig.go

@@ -39,6 +39,7 @@ func (d Docker) GetKubeconfig(node *k3d.Node) (io.ReadCloser, error) {
 		log.Errorln("Failed to create docker client")
 		return nil, err
 	}
+	defer docker.Close()
 
 	container, err := getNodeContainer(node)
 	if err != nil {

pkg/runtimes/docker/network.go

@@ -43,6 +43,7 @@ func (d Docker) CreateNetworkIfNotPresent(name string) (string, bool, error) {
 		log.Errorln("Failed to create docker client")
 		return "", false, err
 	}
+	defer docker.Close()
 
 	// (1) configure list filters
 	args := filters.NewArgs()
@@ -89,6 +90,7 @@ func (d Docker) DeleteNetwork(ID string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// (3) delete network
 	return docker.NetworkRemove(ctx, ID)
@@ -102,5 +104,6 @@ func GetNetwork(ID string) (types.NetworkResource, error) {
 		log.Errorln("Failed to create docker client")
 		return types.NetworkResource{}, err
 	}
+	defer docker.Close()
 	return docker.NetworkInspect(ctx, ID, types.NetworkInspectOptions{})
 }

pkg/runtimes/docker/node.go

@@ -93,6 +93,7 @@ func (d Docker) StartNode(node *k3d.Node) error {
 	if err != nil {
 		return fmt.Errorf("Failed to create docker client. %+v", err)
 	}
+	defer docker.Close()
 
 	// get container which represents the node
 	nodeContainer, err := getNodeContainer(node)
@@ -123,6 +124,7 @@ func (d Docker) StopNode(node *k3d.Node) error {
 	if err != nil {
 		return fmt.Errorf("Failed to create docker client. %+v", err)
 	}
+	defer docker.Close()
 
 	// get container which represents the node
 	nodeContainer, err := getNodeContainer(node)
@@ -151,6 +153,7 @@ func getContainersByLabel(labels map[string]string) ([]types.Container, error) {
 	if err != nil {
 		return nil, fmt.Errorf("Failed to create docker client. %+v", err)
 	}
+	defer docker.Close()
 
 	// (1) list containers which have the default k3d labels attached
 	filters := filters.NewArgs()
@@ -205,10 +208,11 @@ func (d Docker) GetNodeLogs(node *k3d.Node) (io.ReadCloser, error) {
 		log.Errorln("Failed to create docker client")
 		return nil, err
 	}
+	defer docker.Close()
 
 	containerInspectResponse, err := docker.ContainerInspect(ctx, container.ID)
 	if err != nil {
-		log.Errorln("Failed to inspect container '%s'", container.ID)
+		log.Errorf("Failed to inspect container '%s'", container.ID)
 		return nil, err
 	}
 
@@ -243,6 +247,7 @@ func (d Docker) ExecInNode(node *k3d.Node, cmd []string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// exec
 	exec, err := docker.ContainerExecCreate(ctx, container.ID, types.ExecConfig{

pkg/runtimes/docker/volume.go

@@ -40,6 +40,7 @@ func (d Docker) CreateVolume(name string, labels map[string]string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// (1) create volume
 	volumeCreateOptions := volume.VolumeCreateBody{
@@ -70,6 +71,7 @@ func (d Docker) DeleteVolume(name string) error {
 		log.Errorln("Failed to create docker client")
 		return err
 	}
+	defer docker.Close()
 
 	// get volume and delete it
 	vol, err := docker.VolumeInspect(ctx, name)