Switch to using kubelet config file for all supported flags #10433
+316
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
kubelet-config-dir
branch
3 times, most recently
from
c6f443b
to
5b85991
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10433 +/- ##
==========================================
- Coverage 43.03% 41.74% -1.29%
==========================================
Files 163 177 +14
Lines 16534 14931 -1603
==========================================
- Hits 7115 6233 -882
+ Misses 8158 7510 -648
+ Partials 1261 1188 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manuelbuil
previously approved these changes
Jul 1, 2024
Makes logged output more consistent when k3s fails during initialization Signed-off-by: Brad Davidson <[email protected]>
Expose actual error, so that we can tell if the deployment is not found or not ready/available Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
kubelet-config-dir
branch
from
5b85991
to
e56d9f1
Compare
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
kubelet-config-dir
branch
from
e56d9f1
to
ce0e400
Compare
dereknola
reviewed
Jul 2, 2024
| // and a structured configuration file that upstream does not provide a convienent way to initailize with default values. | ||
| // The defaults and our desired config also vary by OS. | ||
| func kubeletArgsAndConfig(cfg *config.Agent) (map[string]string, *kubeletconfig.KubeletConfiguration, error) { | ||
| defaultConfig, err := defaultKubeletConfig(cfg) |
There was a problem hiding this comment.
Is this going to work on Windows? Won't stuff like the cgroup driver fail/be unnecessary on this OS?
There was a problem hiding this comment.
yeah I'm honestly not sure what the windows kubelet does if you try to set the cgroup stuff. I'll try this out in RKE2 before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Switch to using kubelet config file for all supported flags
Types of Changes
enhancement / tech debt
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments
Currently using a hacky string replace when marshaling the config file to work around an upstream issue: