Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator bpfman-operator (0.5.2) #5179

Merged
merged 1 commit into from
Oct 14, 2024
Merged

operator bpfman-operator (0.5.2) #5179

merged 1 commit into from
Oct 14, 2024

Conversation

anfredette
Copy link
Contributor

The bpfman-operator v0.5.2 release is a patch release that adds support for
ppc64le and s390x, and contains several minor internal updates.

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@github-actions GitHub Actions
Copy link
Contributor

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@github-actions github-actions bot changed the title bpfman-operator release v0.5.2 operator bpfman-operator (0.5.2) Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Dear @anfredette,
Some errors and/or warnings were found while doing the check of your operator (bpfman-operator/0.5.2) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value bpfman.io/v1alpha1, Kind=BpfProgram: provided API should have an example annotation
⚠️ Value : (bpfman-operator.v0.5.2) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

msherif1234
msherif1234 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@msherif1234 msherif1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 14, 2024

@msherif1234: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Billy99
Billy99 reviewed Oct 14, 2024
View reviewed changes
operators/bpfman-operator/0.5.2/manifests/bpfman-config_v1_configmap.yaml Outdated
bpfman.agent.image: quay.io/bpfman/bpfman-agent:latest
bpfman.agent.log.level: info
bpfman.agent.metric.addr: 127.0.0.1:8174
bpfman.image: quay.io/bpfman/bpfman:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bpfman.image: quay.io/bpfman/bpfman:latest
bpfman.image: quay.io/bpfman/bpfman:v0.5.2

Do we want latest or v0.5.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to v0.5.2

operators/bpfman-operator/0.5.2/manifests/bpfman-config_v1_configmap.yaml Outdated
apiVersion: v1
data:
bpfman.agent.healthprobe.addr: :8175
bpfman.agent.image: quay.io/bpfman/bpfman-agent:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bpfman.agent.image: quay.io/bpfman/bpfman-agent:latest
bpfman.agent.image: quay.io/bpfman/bpfman-agent:v0.5.2

Do we want latest or v0.5.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to v0.5.2

msherif1234
msherif1234 reviewed Oct 14, 2024
View reviewed changes
operators/bpfman-operator/0.5.2/manifests/bpfman-operator.clusterserviceversion.yaml Outdated
]
capabilities: Basic Install
categories: OpenShift Optional
containerImage: quay.io/bpfman/bpfman-operator:v0.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.5.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

msherif1234
msherif1234 reviewed Oct 14, 2024
View reviewed changes
operators/bpfman-operator/0.5.2/manifests/bpfman-operator.clusterserviceversion.yaml Outdated
env:
- name: GO_LOG
value: debug
image: quay.io/bpfman/bpfman-operator:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.5.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@anfredette anfredette force-pushed the bpfman-operator-release-v0.5.2 branch from 4ed850d to 9dfd4f9 Compare October 14, 2024 22:09
@github-actions GitHub Actions
Copy link
Contributor

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@anfredette
bpfman-operator release v0.5.2
3fae8be 
Signed-off-by: Andre Fredette <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Dear @anfredette,
Some errors and/or warnings were found while doing the check of your operator (bpfman-operator/0.5.2) against the entire suite of validators for Operator Framework with Operator-SDK version v1.36.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value bpfman.io/v1alpha1, Kind=BpfProgram: provided API should have an example annotation
⚠️ Value : (bpfman-operator.v0.5.2) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.

@anfredette anfredette force-pushed the bpfman-operator-release-v0.5.2 branch from 9dfd4f9 to 3fae8be Compare October 14, 2024 22:14
@github-actions GitHub Actions
Copy link
Contributor

Dockerfile or bundle.Dockerfile is added/changed. Note that for security reasons none of these files are going to be used when building bundle. Docker file will be generated and all label information is taken from annotations.yaml.

@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit 899785c into k8s-operatorhub:main Oct 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherif1234 msherif1234 msherif1234 approved these changes

@Billy99 Billy99 Billy99 left review comments

@haripate haripate Awaiting requested review from haripate

@tomasbakk tomasbakk Awaiting requested review from tomasbakk

Assignees

@mporrato mporrato

@Allda Allda

Labels
authorized-changes installation-validated package-validated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anfredette @framework-automation @msherif1234 @Billy99 @mporrato @Allda