crd, Status.IPs: Add omitempty, MinItems attributes

[RamLavi]

This PR is setting the omitempty and MinItems=1 to the IPs field.

Reason: it is essintial to be able to set status attributes (such as conditions) even if the IPs field is empty.
This requires making the attribute omitempty.
Setting the MinItems=1 is meant to avoid setting an empty slice which is confusing according to the API team.

[maiqueb]

Why is this essential ? Can't you just set an empty slice ?

[maiqueb]

This is better.

But I need to see some test checking this out.

[ormergi]

I think we need a complementary MaxItems as well.
And you can also validating the IP itself, using isIP/isCIDR, for example https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/go-controller/pkg/crd/userdefinednetwork/v1/shared.go#L241-L242 https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/go-controller/pkg/crd/userdefinednetwork/v1/shared.go#L232-L234

[maiqueb]

I think we need a complementary MaxItems as well. And you can also validating the IP itself, using isIP/isCIDR, for example https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/go-controller/pkg/crd/userdefinednetwork/v1/shared.go#L241-L242 https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/go-controller/pkg/crd/userdefinednetwork/v1/shared.go#L232-L234

That's off scope.

Not saying it doesn't make sense, just saying it has nothing to do with what we're attempting to do here.

And while saying that, I'm against setting MaxItems in here. The fact you can have at most 2 IPs, one from each family is a limitation I don't want to impose on this CRD.

[RamLavi]

This is better.
But I need to see some test checking this out.

@maiqueb adding this PR on top of ovn-kubernetes/ovn-kubernetes#5683 (see commit) makes the e2e pass (i.e. before- failing, after - passing).
I hope this qualifies as checking it out.

[openshift-merge-robot]

Fix included in accepted release 4.22.0-0.nightly-2026-01-06-164201

[RamLavi]

closing as this change was not accepted by the community