Add conditions status#9
Merged
maiqueb merged 6 commits intoJun 12, 2025
Merged
Conversation
maiqueb
force-pushed
the
add-conditions-status
branch
3 times, most recently
from
42da226 to
1d53b6d
Compare
maiqueb
commented
May 29, 2025
| // The list of IP addresses (v4, v6) that were allocated for the pod interface | ||
| IPs []string `json:"ips"` | ||
| // The name of the pod holding the IPAMClaim | ||
| OwnerPod string `json:"ownerPod"` |
Collaborator
Author
There was a problem hiding this comment.
let's make this also "omitempty".
qinqon
requested changes
May 29, 2025
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-conditions-status
branch
from
1d53b6d to
f219962
Compare
Collaborator
Author
|
@qinqon could you lgtm ? |
Member
|
/lgtm |
This commits adds attributes to the status sub-resource: - status.Conditions: controller can report success / errors while reserving IP addresses for a workload - status.OwnerPod: controller reports which pod owns the allocation Adding conditions to the status is used to inform the user of allocation errors (i.e. no IP addresses available in the subnet, the requested IP addr was already in use, etc) while adding a reference to which pod owns the allocation is used to provide information to the user, and to ensure that a claim in use cannot be used by another workload. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
add-conditions-status
branch
from
f219962 to
e776a9f
Compare
Collaborator
Author
|
These Logged in the meeting's agenda. Going for a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.