Fix go vendor #278
Fix go vendor #278
Conversation
RamLavi
force-pushed
the
fix_go_vendor
branch
from
fc77c1c to
8f9298e
Compare
|
@oshoval any ideas why linter fails? |
|
Please try locally / retest unless you already did, and attach more info if exists / add artifact collector in case needed (not sure we need that deep, but sometimes required) |
|
@oshoval locally (my pc/hades04) running the lint is failing on other things, but the same happens when I run it on main branch so it's unrelated.. |
|
I see dependabot is still trying to bump gprc, maybe merging that will solve the issue? |
|
please rebase. tks |
|
Cool, seems your PR is working. Would you add another commit to address the vendoring discrepancies ? |
|
I think the go version we're using is not playing along w/ the version of the toolchain: i.e. I suspect the go mod's changes are pretty much only the toolchain. Maybe you could align the go version installed w/ the one specified in the toolchain. |
Add a step to run 'make vendor' to ensure the vendor directory is up-to-date, failing the workflow if changes are needed. Signed-off-by: Ram Lavi <[email protected]>
Signed-off-by: Ram Lavi <[email protected]>
|
@maiqueb without the second commit it fails, so if CI passes now we also know it works |
What this PR does / why we need it:
This PR adds a check to CI in order to prevent vendor misalignment
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):