feat: generate SQS resource policies #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skuenzli
changed the title
Resolution error: statement.freeze is not a function
…ses up semantic ordering and orphans @ts-ignore comments
Splitting policy generation and application because: * An SQS queue's resource policy is only modifiable via IQueue#addToResourcePolicy. * The queue policy is not readable. Really! So we generate our policy in a dedicated function so that we can test it.
…supported in SQS Queue policy.
…actions across statements when necessary.
skuenzli
force-pushed
the
feat-generate-sqs-resource-policies
branch
from
0cebb11 to
1feca4e
Compare
…tements before adding to queue's resource policy. If you provide statements as plain objects to addToResourcePolicy, methods like 'freeze' will be missing when synthesizing.
skuenzli
force-pushed
the
feat-generate-sqs-resource-policies
branch
from
1feca4e to
981e458
Compare
skuenzli
force-pushed
the
feat-generate-sqs-resource-policies
branch
from
2a8bd05 to
abd6ddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate SQS Queue resource policies using the k9 Access capability model