Skip to content

fix(inputs): unify outline prop in stories and added it to select#1109

Merged
ferreroltd merged 5 commits intomainfrom
fix/alignment-input-outlines
Oct 24, 2023
Merged

fix(inputs): unify outline prop in stories and added it to select#1109
ferreroltd merged 5 commits intomainfrom
fix/alignment-input-outlines

Conversation

@ferreroltd
Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 72781b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@kadena/react-ui Minor
@kadena/docs Patch
@kadena/graph-client Patch
@kadena/immutable-records Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:42am
docs-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:42am
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:42am
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:42am

@eileenmguo
Copy link
Copy Markdown
Contributor

I don't believe this is the correct style

image image

Comment thread packages/libs/react-ui/src/components/Form/Form.css.ts Outdated
Comment thread packages/libs/react-ui/src/components/Form/TextField/TextField.stories.tsx Outdated
Comment thread .changeset/many-feet-taste.md
Comment thread packages/libs/react-ui/src/components/index.ts
Copy link
Copy Markdown
Contributor

@eileenmguo eileenmguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually it looks a little bit off. It looks like the border padding (in this case outline-offset) is not the same on every side. I would suggest updating the offset to 2px and trying to create the border bottom effect with a box shadow instead
image

Copy link
Copy Markdown
Contributor

@eileenmguo eileenmguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the condition that the styles will be refined in the PR with focus states

@ferreroltd ferreroltd merged commit 62f2f4c into main Oct 24, 2023
@ferreroltd ferreroltd deleted the fix/alignment-input-outlines branch October 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants