Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-example): deploy contract example using @kadena/client #2781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javadkh2
Copy link
Collaborator

@javadkh2 javadkh2 commented Jan 9, 2025

Modify this title

Related Issue/Asana ticket: _

Short description: _

Test scenarios

  • description of the (manually) executed test scenarios

Reminders (if applicable)

  • I ran pnpm install and pnpm test in the root of the monorepo
    (optionally with --filter=...package... to exclude non-affected
    projects)
  • I ran pnpm changeset in the root of the monorepo
  • Test coverage has not decreased
  • Docs have been updated to reflect changes in PR (don't forget
    docs.kadena.io)

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 6497a14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:13am
rwa-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:13am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dev-wallet ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am
explorer ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am
kode-ui ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am
marmalade-marketplace ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am
proof-of-us ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am
tools ⬜️ Skipped (Inspect) Jan 9, 2025 0:13am

@trendzetter
Copy link
Contributor

The example could be improved: it uses hard-coded chain id. It deploys only on one chain, probably more realistic is if it deploys to all chains in parallel. The example uses outdated practices, eg "free" namespace instead of principal namespaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants