Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kadena-dev/eslint-config]: Disable typedef var for react #383

Closed
wants to merge 6 commits into from

Conversation

eileenmguo
Copy link
Contributor

@eileenmguo eileenmguo commented Jun 12, 2023

Reason:

Discussed with Albert a long time ago that it might not be that necessary to enable this rule for react applications since variables are often assigned as const/styled objects. This disables this rule for projects that use the react or next.js eslint profiles.

Changes made (preferably with images/screenshots):

Check off the following:

  • I have reviewed my changes and run the appropriate tests.
  • I have have run rush change to add the appropriate change logs.
  • I have added/edited docs.
  • I have added tutorials.
  • I have double checked and DEFINITELY added docs.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2023 9:32am

@eileenmguo eileenmguo changed the title disable typedef var for react [@kadena-dev/eslint]: Disable typedef var for react Jun 12, 2023
@eileenmguo eileenmguo changed the title [@kadena-dev/eslint]: Disable typedef var for react [@kadena-dev/eslint-config]: Disable typedef var for react Jun 12, 2023
@eileenmguo eileenmguo closed this Jun 12, 2023
@eileenmguo eileenmguo deleted the eslint-config/disable-typedef-var-react branch June 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant