Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timeSpanToMicros and add tests #1256

Merged
merged 2 commits into from
Jul 9, 2021
Merged

fix timeSpanToMicros and add tests #1256

merged 2 commits into from
Jul 9, 2021

Conversation

larskuhtz
Copy link
Contributor

@larskuhtz larskuhtz commented Jul 9, 2021 •
edited
Loading

This change is factored out from #1244 where it got already approved.

@larskuhtz larskuhtz merged commit 8b0e23e into master Jul 9, 2021
@larskuhtz larskuhtz deleted the lars/fix/timeSpanToMicros branch July 9, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirlensalot sirlensalot sirlensalot approved these changes

@emmanueldenloye emmanueldenloye emmanueldenloye approved these changes

@mightybyte mightybyte Awaiting requested review from mightybyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larskuhtz @sirlensalot @emmanueldenloye