Skip to content

Conversation

@junaid-ali
Copy link
Contributor

@junaid-ali junaid-ali commented Oct 26, 2025

fixes: #1440

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Copied the index digest from: https://hub.docker.com/layers/azul/zulu-openjdk-alpine/21.0.8-jre-headless/images, so it should now correctly work on both amd64 and arm64 machines

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
    Manually pulled the digest and ran it on both an amd64 and an arm64 (graviton) machine
## ------------------ arm64

$ tag=sha256:48356cf1b81243b6e236509bb6ae281969fc0eade03f622220973a4e224cd768
$ uname -i
aarch64
$ ctr i pull docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag
...
unpacking linux/arm64/v8 sha256:48356cf1b81243b6e236509bb6ae281969fc0eade03f622220973a4e224cd768...
done: 7.351239ms

$ crictl inspecti docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag | jq -r .info.imageSpec.architecture
arm64

$ ctr run --rm -t docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag test ash
/ #


## ------------------ amd64

$ tag=sha256:48356cf1b81243b6e236509bb6ae281969fc0eade03f622220973a4e224cd768
$ uname -i
x86_64
$ ctr i pull docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag
...
unpacking linux/amd64 sha256:48356cf1b81243b6e236509bb6ae281969fc0eade03f622220973a4e224cd768...
done: 8.933226ms

$ crictl inspecti docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag | jq -r .info.imageSpec.architecture
amd64

$ ctr run --rm -t docker.io/azul/zulu-openjdk-alpine:21.0.8-jre-headless@$tag test ash
/ #
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@junaid-ali junaid-ali requested a review from a team as a code owner October 26, 2025 23:04
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 26, 2025
@junaid-ali
Copy link
Contributor Author

I think we should ideally have some tests as well so that it won't break in future.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi junaid-ali! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean closed this Oct 28, 2025
@Haarolean Haarolean reopened this Oct 28, 2025
@Haarolean Haarolean added scope/backend Related to backend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels Oct 28, 2025
@Haarolean Haarolean added this to the 1.4 milestone Oct 28, 2025
@Haarolean Haarolean self-requested a review October 28, 2025 06:37
@Haarolean Haarolean changed the title fix: use the correct digest for azul/zulu-openjdk-alpine Update base image sha Oct 28, 2025
@Haarolean Haarolean enabled auto-merge (squash) October 28, 2025 06:39
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.4 Oct 28, 2025
@Haarolean
Copy link
Member

I think we should ideally have some tests as well so that it won't break in future.

yeah, see #560

@junaid-ali
Copy link
Contributor Author

Thanks @Haarolean for the review and approval.

@Haarolean Haarolean merged commit c1841e6 into kafbat:main Oct 28, 2025
30 of 32 checks passed
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.4 Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

BE: Exec format error on main tag

2 participants