-
-
Notifications
You must be signed in to change notification settings - Fork 214
BE: Support PEM trust/key stores and mTLS configuration. (#1437) #1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi iamtakingiteasy! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
ce8c9fa to
dc3d50c
Compare
| type: string | ||
| password: | ||
| type: string | ||
| keystoreType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamtakingiteasy openapi spec here is outdated/a backup, typespec (*.tsp) files need to be obe updated to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haarolean It is updated accordingly as well, see model KeystoreConfig / enum StoreType / enum SecurityProtocol and corresponding references. I don't see anything missing; kafkaConnect.keystoreType is updated to StoreType among other things.
|
Playwright E2E seem flaky, passed on the same commit on fork repo; requesting re-run from someone with permissions. |
dc3d50c to
b94ce2c
Compare
|
Wait, no. it's actually was ran on different commit than PR branch.
which is a merge into current upstream, when passing commit is dc3d50c -- nonconflicting, but as of now already behind the upstream main branch, rebased. |
What changes did you make?
Resolves #1437
Adds support for PEM keystore/truststore and mTLS configuration, replacing manual KeyManagerFactory/TrustManagerFactory calls with spring boot SslBundle to parametrize the kafka client and http/netty clients.
TruststoreConfig/KeystoreConfigextended withtruststoreType/keystoreTypewith possible values of JKS, PKCS12 and PEMKeystoreConfigis extended withkeystoreCertificatefor [pem] client certificate file.Clusteris extended withsecurityProtocolandkafkaSslfor mTLS client certificate.Out-of-the scope FE change:
ApplicationConfigPropertiesKafkaSchemaRegistrySsl->KeystoreConfigas reusable DTO is introduced, auto-generated one no longer exists.Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)