Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed active sidebar menu is highlighted for the correct Kafka instance #324 #540

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AlexisD02
Copy link

@AlexisD02 AlexisD02 commented Sep 11, 2024

What changes did you make?

This pull request addresses a bug in Kafka UI where it was not clear which Kafka instance was being displayed. Previously, the sidebar options (e.g., Topics, Brokers, Consumers) were highlighted for all Kafka instances, causing confusion.

Changes Include:

  • Updated the page header to display <instance name> Topics instead of just "Topics" to clearly indicate which Kafka instance is being viewed.
  • Ensured that the selected menu option is highlighted only for the Kafka instance currently being displayed, improving the clarity of navigation.

Is there anything you'd like reviewers to focus on?

Please review the changes to ensure:

  • The page header correctly reflects the current Kafka instance.
  • The sidebar highlights only the selected menu option for the active Kafka instance.

Fixes #694

@AlexisD02 AlexisD02 requested a review from a team as a code owner September 11, 2024 13:43
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 11, 2024
@AlexisD02 AlexisD02 changed the title Fixed active sidebar menu is highlighted for the correct Kafka instance Fixed active sidebar menu is highlighted for the correct Kafka instance #324 Sep 11, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how is this related to #324 which is about tab's title?

@AlexisD02
Copy link
Author

I don't get how is this related to #324 which is about tab's title?

Thanks for pointing this out! I looked for the issue related to my task but couldn't find anything. Could you point me to the correct issue if I'm missed something?

@Haarolean
Copy link
Member

I don't get how is this related to #324 which is about tab's title?

Thanks for pointing this out! I looked for the issue related to my task but couldn't find anything. Could you point me to the correct issue if I'm missed something?

I believe there's no issue related to these changes. I haven't experienced the issue you're describing either, as this is supposed to be a bugfix, let's file a bug report first, as I'm not being able to reproduce this.
image

@Haarolean Haarolean marked this pull request as draft September 27, 2024 22:31
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
@hotsezus
Copy link

hotsezus commented Dec 4, 2024

I'm experiencing the same issue using main tagged image from docker hub
image

@Haarolean
Copy link
Member

@hotsezus any specific steps to reproduce?

@hotsezus
Copy link

hotsezus commented Dec 4, 2024

@hotsezus any specific steps to reproduce?

Nothing special. Just use kafbat/kafka-ui:e7df880cdebe3977d06edee54a538bcaf9416649 image setting up connection to multiple clusters using config.yaml

Here is a compose.yml example:

services:
  kafbat-ui:
    image: kafbat/kafka-ui:e7df880cdebe3977d06edee54a538bcaf9416649
    restart: on-failure
    ports:
      - 8080:8080
    environment:
      DYNAMIC_CONFIG_ENABLED: 'true'
    volumes:
      - ./config.yml:/etc/kafkaui/dynamic_config.yaml

@Haarolean Haarolean self-assigned this Dec 4, 2024
@Haarolean Haarolean requested a review from Leshe4ka December 5, 2024 11:30
@Haarolean Haarolean removed their assignment Dec 5, 2024
@Haarolean Haarolean dismissed their stale review December 5, 2024 11:30

outdated

@Haarolean Haarolean requested a review from Mgrdich February 19, 2025 09:54
@Haarolean Haarolean marked this pull request as ready for review February 19, 2025 09:54
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels Feb 19, 2025
@@ -38,6 +38,7 @@ const ResetOffsets: React.FC = () => {
return (
<>
<PageHeading
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of giving the Pageheading cluaterName couldn't we just use the hook param inside and get it there since we are giving it everywhere

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexisD02 could you address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experiense issues hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: UX: Multiple clusters' menu items selected at once
4 participants