BE: Chore: use record classes #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
yeikel
force-pushed
the
refactor-record
branch
4 times, most recently
from
c083660 to
fc1e8cc
Compare
Haarolean
added
scope/backend
yeikel
force-pushed
the
refactor-record
branch
3 times, most recently
from
d4e3423 to
c1870b6
Compare
yeikel
force-pushed
the
refactor-record
branch
from
c1870b6 to
0e85faa
Compare
|
@Haarolean What is blocking the merge of this change? Thanks in advance! |
Haarolean
requested changes
Dec 24, 2024
| public SchemaDescription(String schema, Map<String, Object> additionalProperties) { | ||
| this.schema = schema; | ||
| this.additionalProperties = additionalProperties; | ||
| public SchemaDescription { |
There was a problem hiding this comment.
do we need a default constructor here?..
| */ | ||
| public final class DeserializeResult { | ||
| public record DeserializeResult(String result, io.kafbat.ui.serde.api.DeserializeResult.Type type, |
There was a problem hiding this comment.
io.kafbat.ui.serde.api.DeserializeResult.Type - can we import this?
String result - @nullable won't hurt I guess considering the comment we had on line 16
| @@ -67,11 +68,6 @@ public boolean equals(Object o) { | |||
| && additionalProperties.equals(that.additionalProperties); | |||
| } | |||
|
|
|||
| @Override | |||
| public int hashCode() { | |||
| return Objects.hash(result, type, additionalProperties); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Refactors the code to take advantage of records
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)