-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE: Fix Default Consumer's Lag Value with nullish coalescing #720
base: main
Are you sure you want to change the base?
Conversation
e08de4f
to
f03f496
Compare
Please cover your changes with unit tests, thanks. |
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
Before adding unit test code, I will first explain my position on your response. The intention is to apply the results you tested in the console to the actual service. When you test on the console, if 0 is assigned to the variable value, When you run the existing code, you may have seen it displayed as 'N/A'. However, in the code I modified, it be displayed as 0. This is my intention with this example. This is because 'N/A' has a different meaning from '0'. To summarize again: I only want to mark as N/A situations where Consumer Lag cannot be delivered due to an actual problem within the server, such as a Null on the server, or a problem within the Kafka ecosystem. I think '0' and 'N/A' should be interpreted differently. |
Thanks for the additional feedback! We'll get back to your issue soon. |
69759af
to
1ad8cb8
Compare
138c1d1
to
a4c3eca
Compare
close #675
The default value of Consumer Lag displayed when searching the Consumer List has been modified.
The existing displayed value is 'N/A', which is different from the response value of '0' that the server responds to.
We believe that 'N/A' may mean a state of disuse, so we write it as 0 to make it clear.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)