FE: Messages: Implement messages export #740
Conversation
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi alexanderlz! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Haarolean
added
type/enhancement
|
definitely (both of your questions). Happy New Year! |
likewise, happy new year 😊 |
| buttonSize="M" | ||
| onClick={handleDownload} | ||
| > | ||
| Download All Messages |
There was a problem hiding this comment.
The text Download All Messages may be a bit misleading as this will only download the messages of the current page. Can we reword it to "Download Current Page Messages" or similar?
In the future we may want to expose an actual "Download all the messages" that will paginate and download the messages
| const minutes: string = now.getMinutes().toString().padStart(2, '0'); | ||
| const seconds: string = now.getSeconds().toString().padStart(2, '0'); |
There was a problem hiding this comment.
Is this padding necessary? Can you add an inline comment explaining why we are doing that if so?
There was a problem hiding this comment.
the padding is for more human readable format (e.g. 07:02:04)
will add a comment for that
There was a problem hiding this comment.
can't we use some time lib here? I believe we had some in use already (dayjs?)
What changes did you make? (Give an overview)
Added an option to download all messages that are displayed on page(as csv or json)
as per #688
useDataSaver method is reused here.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
