Repository navigation
chore: upgrade tailwind-merge and hookform resolvers - #31
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tailwind-merge1.14.0 -> 3.6.0 — one call site,cn()inlib/utils.ts@hookform/resolvers3.10.0 -> 5.5.7 — one call site,zodResolverinUrlFormNeither needed a code change.
Closes a real coverage gap
zodResolveris the seam between zod 4 and resolvers 5 — the only place the two majors meet — and nothing covered it.UrlFormsits behind authentication, so the e2e suite cannot reach it.lib/resolver.test.mtsnow tests the adapter directly: valid input passes through, an invalid scheme surfaces the schema's own message on the right field, and a missing url is reported rather than thrown.Verified non-vacuous — changing the expected message makes it fail (17 pass / 1 fail), restoring it returns 18.
Not covered
tailwind-mergeonly affects class-string merging, which no test exercises. The risk is visual rather than functional, andcn()is a single pass-through, so I did not add a test for it.Testing
pnpm test:unit— 18 passed (3 new)pnpm test:e2e— 9 passedpnpm lint/pnpm format:check— cleanpnpm build— compiles