Repository navigation
chore: drop eslint in favour of oxlint alone - #33
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kahlstrm
force-pushed
the
chore/drop-eslint
branch
from
August 2, 2026 19:27
a5711c2 to
163f622
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes ESLint entirely.
pnpm lintis now justoxlint --max-warnings=0.eslint,eslint-plugin-react-hooksand@typescript-eslint/parserare gone, along witheslint.config.mjs. 796 -> 679 packages.What this gives up
ESLint was kept in #27 solely for the React Compiler-era rules that oxlint does not implement:
set-state-in-render,set-state-in-effect,immutability,purity,refs,static-components,use-memo.Those are now unenforced. Demonstrated rather than assumed — this passes
pnpm lintcleanly:The exposure is three first-party components (
UrlForm,UrlList,CopyToClipBoard) and noReact Compiler, so it is small — but it is a real reduction, and the README now says so.
What is still covered
oxlint keeps
rules-of-hooksandexhaustive-deps, both explicitly enabled. Verified: aconditionally-called hook still errors.
Also unchanged — Next.js rules, jsx-a11y, react, import, TypeScript and unicorn.
Testing
pnpm lint— clean, and verified it still catchesrules-of-hookspnpm test:unit— 18 passedpnpm test:e2e— 9 passedpnpm format:check— cleanpnpm build— compiles