Skip to content

chore: drop eslint in favour of oxlint alone - #33

Merged
kahlstrm merged 1 commit into
mainfrom
chore/drop-eslint
Aug 2, 2026
Merged

kahlstrm merged 1 commit into
mainfrom
chore/drop-eslint

Conversation

@kahlstrm

@kahlstrm kahlstrm commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

Removes ESLint entirely. pnpm lint is now just oxlint --max-warnings=0.

eslint, eslint-plugin-react-hooks and @typescript-eslint/parser are gone, along with
eslint.config.mjs. 796 -> 679 packages.

What this gives up

ESLint was kept in #27 solely for the React Compiler-era rules that oxlint does not implement:
set-state-in-render, set-state-in-effect, immutability, purity, refs,
static-components, use-memo.

Those are now unenforced. Demonstrated rather than assumed — this passes pnpm lint cleanly:

export function Bad() {
  const [n, setN] = useState(0);
  setN(n + 1);        // setState during render: infinite re-render
  return <p>{n}</p>;
}

The exposure is three first-party components (UrlForm, UrlList, CopyToClipBoard) and no
React Compiler, so it is small — but it is a real reduction, and the README now says so.

What is still covered

oxlint keeps rules-of-hooks and exhaustive-deps, both explicitly enabled. Verified: a
conditionally-called hook still errors.

Also unchanged — Next.js rules, jsx-a11y, react, import, TypeScript and unicorn.

Testing

  • pnpm lint — clean, and verified it still catches rules-of-hooks
  • pnpm test:unit — 18 passed
  • pnpm test:e2e — 9 passed
  • pnpm format:check — clean
  • pnpm build — compiles

@vercel

vercel Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
next-shortener Ready Ready Preview Aug 2, 2026 7:28pm

@kahlstrm
kahlstrm force-pushed the chore/drop-eslint branch from a5711c2 to 163f622 Compare August 2, 2026 19:27
@kahlstrm
kahlstrm merged commit 34af426 into main Aug 2, 2026
4 checks passed
@kahlstrm
kahlstrm deleted the chore/drop-eslint branch August 2, 2026 19:37

This branch was successfully deployed

1 active deployment
Preview — 163f6222 Deployed Aug 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant