blockchain/vm: fix onlyTopCall discarding the top frame's logs - #1027
Open
2dvorak wants to merge 1 commit into
Open
blockchain/vm: fix onlyTopCall discarding the top frame's logs#10272dvorak wants to merge 1 commit into
onlyTopCall discarding the top frame's logs#10272dvorak wants to merge 1 commit into
Conversation
callTracer with `{"withLog":true,"onlyTopCall":true}` returned no logs at all,
including the top frame's own: `depth` is the opcode depth, which counts active
frames and therefore reads 1 while the top frame executes, not 0.
2dvorak
marked this pull request as ready for review
August 10, 2026 06:19
2dvorak
requested review from
hyunsooda,
ian0371 and
yoomee1313
as code owners
August 10, 2026 06:19
hyunsooda
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
withLog && onlyTopCallreturned no logs at all, including the top frame's owndepthis the opcode depth, which counts active frames and therefore reads 1 while the top frame executes, not 0> 0to> 1accordinglyTypes of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Before refactoring, geth had the same issue.
Further comments