Skip to content

Conversation

@kaic
Copy link
Owner

@kaic kaic commented Dec 10, 2025

Summary

Fixes catalog validation errors discovered by automated tests and resolves pre-existing eslint issues.

Issues Found

The new Jest validation suite (1158 tests) discovered:

  1. LastPass using invalid category security-privacy instead of security
  2. Unused imports in script-utils.js
  3. ESLint errors in context files blocking CI pipeline

Changes

Catalog fixes:

  • Moved LastPass from security-privacy/ to security/ directory
  • Updated category field and import path in aggregator
  • Removed empty security-privacy directory

Lint fixes:

  • Removed unused imports in script-utils.js
  • Fixed SelectionContext.jsx: lazy initialization instead of setState in useEffect
  • Fixed ThemeContext.jsx: proper context export pattern

Testing

  • All 1158 validation tests pass
  • Build succeeds
  • Lint passes with 0 errors

Validation Coverage

Tests validate: software/config schemas, category enums, license enums, unique kebab-case IDs, winget ID format, hex colors, non-empty command arrays.

This PR demonstrates the new CI pipeline catching real issues before merge.

@kaic kaic changed the title fix: move LastPass to correct security category fix: resolve catalog validation errors and eslint issues Dec 10, 2025
@kaic kaic merged commit 9e33f00 into main Dec 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants