feat: auto-discover software and configurations using Vite glob #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual imports in software-catalog.js and configurations.js with Vite's import.meta.glob for automatic discovery of items from their folder structure. Benefits: - Adding new software/config only requires creating a single file - No more manual editing of aggregator files - Reduces maintenance burden and prevents missed updates Changes: - Refactor software-catalog.js to use import.meta.glob (~320 -> ~50 lines) - Refactor configurations.js to use import.meta.glob (~260 -> ~50 lines) - Add Jest test helpers using Node.js glob for test compatibility - Update tests to use async loading in beforeAll - Add glob as dev dependency
Owner
|
Great PR man, approved. This will save a lot of work. Thanks. |
kaic
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
import.meta.globfor automatic file discoverysoftware-catalog.jsorconfigurations.jsChanges
import.meta.glob('./software/**/*.js', { eager: true })import.meta.glob('./configurations/**/*.js', { eager: true })glob-based loaders for Jest compatibility (Jest doesn't supportimport.meta.glob)beforeAllBenefits
.jsfile in the right folder and it's automatically includedTest plan
npm run buildpassesnpm testpasses (17 tests)npm run devstarts correctly