Skip to content

fix: improve dark theme contrast #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaic merged 1 commit into from
Dec 15, 2025
Merged

fix: improve dark theme contrast #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Common/Badge.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const Badge = ({ color, textColor = 'white', children }) => {
return (
<span
className="px-1 text-[10px] border border-black"
className="inline-flex items-center px-1.5 py-0.5 text-[10px] leading-none border border-black"
style={{
backgroundColor: color,
color: textColor,
Expand Down
10 changes: 6 additions & 4 deletions src/components/Common/SoftwareIcon.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ const SoftwareIcon = ({ iconName, color, size = 24 }) => {
const Icon = Icons[iconName] || Icons.FiPackage;

return (
<Icon
size={size}
style={{ color: color || '#6B7280', flexShrink: 0 }}
/>
<span className="software-icon" style={{ display: 'inline-flex', flexShrink: 0 }}>
<Icon
size={size}
style={{ color: color || '#6B7280' }}
/>
</span>
);
};

Expand Down
2 changes: 1 addition & 1 deletion src/components/ConfigurationSelector/ConfigOption.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ConfigOption = memo(({ config }) => {
<h4
className="text-[11px] font-bold"
style={{
color: isSelected ? 'var(--win98-white)' : 'var(--win98-black)'
color: isSelected ? 'var(--win95-text-inverse)' : 'var(--win98-black)'
}}
>
{config.name}
Expand Down
2 changes: 1 addition & 1 deletion src/components/ConfigurationSelector/ConfigSection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const ConfigSection = ({ category, configs }) => {
<div style={{ fontSize: '13px', fontWeight: 'bold', marginBottom: '3px', lineHeight: '1.2' }}>
{category.name}
</div>
<div className="category-description" style={{ fontSize: '11px', fontWeight: 'normal', color: '#000', lineHeight: '1.3' }}>
<div className="category-description" style={{ fontSize: '11px', fontWeight: 'normal', color: 'var(--win95-black)', lineHeight: '1.3' }}>
{category.description}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/SoftwareSelector/CategorySection.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const CategorySection = ({ category, software }) => {
<div style={{ fontSize: '13px', fontWeight: 'bold', marginBottom: '3px', lineHeight: '1.2' }}>
{category.name}
</div>
<div className="category-description" style={{ fontSize: '11px', fontWeight: 'normal', color: '#000', lineHeight: '1.3' }}>
<div className="category-description" style={{ fontSize: '11px', fontWeight: 'normal', color: 'var(--win95-black)', lineHeight: '1.3' }}>
{category.description}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/SoftwareSelector/SoftwareCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const SoftwareCard = memo(({ software }) => {
<div
className="flex items-center gap-1.5 flex-wrap text-[11px] font-bold"
style={{
color: isSelected ? 'var(--win98-white)' : 'var(--win98-black)'
color: isSelected ? 'var(--win95-text-inverse)' : 'var(--win98-black)'
}}
>
<span>{software.name}</span>
Expand Down
37 changes: 22 additions & 15 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
--win95-medium-gray: #C0C0C0;
--win95-dark-gray: #7A7A7A;
--win95-black: #000000;
--win95-text-inverse: #FFFFFF;

/* Accent Colors - Flat */
--win95-blue: #000080;
Expand Down Expand Up @@ -74,7 +75,7 @@ body {
.xp-title-bar {
height: 20px;
background-color: var(--win95-blue); /* FLAT COLOR - NO GRADIENT */
color: var(--win95-white);
color: var(--win95-text-inverse);
font-weight: bold;
font-size: var(--win95-font-size);
padding: 2px 4px;
Expand Down Expand Up @@ -179,14 +180,14 @@ body {
.win95-button:hover:not(:disabled),
.xp-button:hover:not(:disabled) {
background-color: var(--win95-dark-gray);
color: var(--win95-white);
color: var(--win95-text-inverse);
border-color: var(--win95-black);
}

.win95-button:active:not(:disabled),
.xp-button:active:not(:disabled) {
background-color: var(--win95-dark-gray);
color: var(--win95-white);
color: var(--win95-text-inverse);
transform: translateY(1px); /* PRESSED OFFSET */
}

Expand All @@ -204,7 +205,7 @@ body {
.win95-button-primary,
.xp-button-primary {
background-color: var(--win95-blue); /* FLAT BLUE */
color: var(--win95-white);
color: var(--win95-text-inverse);
font-weight: bold;
border-color: var(--win95-black);
}
Expand All @@ -227,7 +228,7 @@ body {
.win95-button-danger,
.xp-button-danger {
background-color: var(--win95-red); /* FLAT RED */
color: var(--win95-white);
color: var(--win95-text-inverse);
font-weight: bold;
border-color: var(--win95-black);
}
Expand Down Expand Up @@ -340,7 +341,7 @@ body {
.win95-selected,
.xp-selected {
background-color: var(--win95-blue); /* FLAT BLUE */
color: var(--win95-white);
color: var(--win95-text-inverse);
border-color: var(--win95-black);
}

Expand All @@ -366,7 +367,7 @@ body {
.win95-menu-item:hover,
.xp-menu-item:hover {
background-color: var(--win95-blue);
color: var(--win95-white);
color: var(--win95-text-inverse);
}

/* ================================================== */
Expand Down Expand Up @@ -422,7 +423,7 @@ body {
/* ================================================== */

.win95-text-black { color: var(--win95-black); }
.win95-text-white { color: var(--win95-white); }
.win95-text-white { color: var(--win95-text-inverse); }
.win95-text-gray { color: var(--win95-dark-gray); }
.win95-bg-window { background-color: var(--win95-light-gray); }
.win95-bg-white { background-color: var(--win95-white); }
Expand All @@ -431,7 +432,7 @@ body {

/* Legacy XP utility classes - mapped to Win95 */
.xp-text-black { color: var(--win95-black); }
.xp-text-white { color: var(--win95-white); }
.xp-text-white { color: var(--win95-text-inverse); }
.xp-text-gray { color: var(--win95-dark-gray); }
.xp-bg-window { background-color: var(--win95-light-gray); }
.xp-bg-white { background-color: var(--win95-white); }
Expand Down Expand Up @@ -484,19 +485,19 @@ body {

.win98-button:hover:not(:disabled) {
background-color: var(--win95-dark-gray);
color: var(--win95-white);
color: var(--win95-text-inverse);
border-color: var(--win95-black);
}

.win98-button:active:not(:disabled) {
background-color: var(--win95-dark-gray);
color: var(--win95-white);
color: var(--win95-text-inverse);
transform: translateY(1px);
}

.win98-button-primary {
background-color: var(--win95-blue);
color: var(--win95-white);
color: var(--win95-text-inverse);
font-weight: bold;
border-color: var(--win95-black);
}
Expand All @@ -507,7 +508,7 @@ body {

.win98-button-danger {
background-color: var(--win95-red);
color: var(--win95-white);
color: var(--win95-text-inverse);
font-weight: bold;
border-color: var(--win95-black);
}
Expand Down Expand Up @@ -554,7 +555,7 @@ body {

.win98-selected {
background-color: var(--win95-blue);
color: var(--win95-white);
color: var(--win95-text-inverse);
border-color: var(--win95-black);
}

Expand Down Expand Up @@ -599,7 +600,7 @@ input:focus-visible {
top: -40px;
left: 0;
background: var(--win95-blue);
color: var(--win95-white);
color: var(--win95-text-inverse);
padding: 8px;
text-decoration: none;
z-index: 100;
Expand All @@ -620,6 +621,7 @@ input:focus-visible {
--win95-medium-gray: #3d3d3d;
--win95-dark-gray: #a0a0a0;
--win95-black: #e0e0e0;
--win95-text-inverse: #ffffff;

/* Accent Colors - Adjusted for dark mode contrast */
--win95-blue: #4040c0;
Expand All @@ -639,6 +641,11 @@ input:focus-visible {
--win98-white: #1a1a1a;
}

/* Subtle icon outline for dark mode visibility */
.dark .software-icon svg {
filter: drop-shadow(0 0 0.75px rgba(255, 255, 255, 0.6));
}

/* Dark mode body background */
.dark body,
body.dark {
Expand Down