convert to C #16
convert to C #16
Conversation
it's ridiculous to add dependency on a C++ compiler and the complexity of a mixed build for the sake of using a single class and new/delete operators.
|
This is a good one @kallisti5 ! |
|
Usin standar well know makefile is better rather than a scons dependency that pull to install more things in my linux |
i tried like 5 minutes to get a list of command line options using the regular --help, -? and what have you, but didn't figure out the magic incantation "-h" on my own.
for parameters requiring an argument when none was passed.
the 24bit, surface-based, directly-using-opengl code resulted in huexpress running at 100% cpu load at about 30% native speed on my machine. using SDL2's hardware-accelerated texture rendering primitives instead (with 32bit textures), it now runs at 20% cpu use at full speed.
this makes it possible to override settings from the ini file from the command line.
this will also be used if the logfile fails to open.
|
added some commits to make rendering performance 15x faster, and fix the command line parser. |
|
I'm not really interested in moving away from SCons. Lots of upstream packages / recipes are written around us using SCons. Could the makefile change be opened into a separate PR to discuss? Everything else looks fine. |
|
@kallisti5 i updated the SCons scripts and added a note to INSTALL that the makefile isn't supported, so imo it can be kept as a bonus but users that prefer scons know that it'll work and that's what's supposed to be used. |
additionally to F9, which was used in the past, although it probably never worked anyway, at least since the SDL2 move.
this happened when loading an iso from a .zip while no system card roms were present in the paths searched.
PCEngine_Run() will cause accesses to uninitialized structures after PCEngine_LoadFile() returned error.
the problem with scons is that it depends of upstream and in some distros is not packaged.. also it changed with time to time.. currently i can build a piece of software with makefile with any version of.. not the same with scons or cmake if there's some change across versions |
also this PR doesn't remove or deprecate scons, it simply adds the Makefile as an option - and since it's now documented as unofficial you won't have to maintain it. |
gcc10 defaults to -fno-common and this results in a link error. this patch also happens to be in freebsd's hugo tree: https://cgit.freebsd.org/ports/tree/emulators/hugo/files/patch-osd__sdl__gfx.c
src/osd_keyboard.c:450:29: warning: passing argument 1 of 'SDL_JoystickName' makes pointer from integer without a cast [-Wint-conversion]
|
@rofl0r the makefile works like a baby.. .. about compilation it compiles in any machine.. i was using older debian wheeze i tested and found a minimal detail.. when any rom started.. there's a peak of sound at start tht almost break my ears (with hearphones) i dont know if there's a inheric detail or a consecuence,
|
i experienced this too when i started hacking on huexpress (so it seems to be an old issue) but it disappeared for me after b17df90 because before that commit huexpress was only running at like 20% speed so the sound was heavily distorted. |
No description provided.