Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIV-1205: Transcoder overload protection. #181

Merged
merged 8 commits into from
Nov 13, 2023

Conversation

igorshevach
Copy link
Contributor

@igorshevach igorshevach commented Nov 6, 2023

  • add throttler.h,c

  • define config throttler.maxDataRate as max limit on transcoder usage.

    • measured in times x normal fps. e.g. if maxDataRate = 2 we expect no more than twice the original throughput.
    • By default maxDataRate is set to Infinity and no data rate limit is performed.
  • define throttler.useStatsDataRate , bool (defaults: false) as a fallback suggesting use of stream times when estimating data rate. By default, given known fps (or packet per seconds, pps) throttler won't use dts'es as unreliable and calculate the rate from given target fps. NOTE: There are audio codecs like opus, where fps is not known and requires parsing packet header to determine actual number of audio samples, thus complicating the rate calculation.On the other hand, given aac is used most of the times the pps can be derived from a configuration data or assumed to be some max threshold value (e.g. 960 samples per frame)

- define config throttler.maxDataRate as max limit on transcoder usage.
   * measured in times x normal fps. e.g. if maxDataRate = 2 we expect
   no more than twice the original throughput.
   * By default maxDataRate is set to Infinity and no data rate limit is performed.
@igorshevach igorshevach changed the title Limit data flow rate through transcoder. LIV-1205: Transcoder overload protection. Nov 8, 2023
@david-winder-kaltura david-winder-kaltura merged commit b574371 into master Nov 13, 2023
8 checks passed
@david-winder-kaltura david-winder-kaltura deleted the master-throttle-transcoder branch November 13, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants