Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ADA-2126): Player - Share overlay is missing labels #61

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(ADA-2126): Player - Share overlay is missing labels #61

merged 1 commit into from
Jan 6, 2025

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Jan 2, 2025 •
edited by jira bot
Loading

Description of the Changes

Issue:
share clip inputs don't have valid aria-label (the labelledby id does not exist).

Fix:
adding aria-label to share clip inputs

Solves ADA-2126

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 1a4ad97 into master Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheMaorKaltura MosheMaorKaltura MosheMaorKaltura approved these changes

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tzipi-kaltura @MosheMaorKaltura @lianbenjamin