Open
Conversation
zaquestion
approved these changes
Dec 6, 2022
zaquestion
left a comment
zaquestion
left a comment
There was a problem hiding this comment.
This looks great, and solid cleanup on the file names :)
Co-authored-by: Kamal Nasser <hello@kamal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the option to delete a URL endpoint for all storage drivers. The DELETE http verb can now be passed with the curl command. Another change was made as well: for the file storage driver, a directory called 'urls' (default path) is created automatically if it does not already exist and no other path is specified.
Issue ticket link
#14
How has this been tested?
Tested using memory and file storage drivers. Sample run:
