Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented delete URL endpoint #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

am831
Copy link

@am831 am831 commented Dec 3, 2022

Description

Implemented the option to delete a URL endpoint for all storage drivers. The DELETE http verb can now be passed with the curl command. Another change was made as well: for the file storage driver, a directory called 'urls' (default path) is created automatically if it does not already exist and no other path is specified.

Issue ticket link

#14

How has this been tested?

Tested using memory and file storage drivers. Sample run:
memory

Copy link

@zaquestion zaquestion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and solid cleanup on the file names :)

Copy link
Owner

@kamaln7 kamaln7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for adding this, @am831 😃🎉

Co-authored-by: Kamal Nasser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants