Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to objects in array documents and object documents #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kubak89
Copy link

@kubak89 kubak89 commented Aug 7, 2020

According to this discussion on Json:API forums, resources in primary data may have relationships with other resources that are also there (e.g. two "people" type resources with HasOne relationships referencing each other in "spouse" field). The library have not supported such a case, so I added find(ResourceIdentifier) method overrides in ArrayDocument and ObjectDocument that allow searching for referenced Resource in data field.

…ent that would allow finding referenced resources in ArrayDocument data list
…ment that would allow finding referenced resources in ObjectDocument data
@kubak89 kubak89 force-pushed the references-to-objects-in-array-documents-and-object-documents branch from 9ea5588 to dbc984d Compare August 7, 2020 14:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 82.262% when pulling dbc984d on codequest-eu:references-to-objects-in-array-documents-and-object-documents into 3582cd6 on kamikat:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants