Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kamon-pekko-http #1285

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Add kamon-pekko-http #1285

merged 6 commits into from
Aug 10, 2023

Conversation

DieBauer
Copy link
Contributor

@DieBauer DieBauer commented Jul 15, 2023 •
edited
Loading

Since Akka changed its license to BSL, an Apache fork of Akka was made: Apache Pekko (and Apache Pekko Http).

An initial release is released, and the major change is that the namespaces changed from akka. to org.apache.pekko..

This PR adds the first module that copy the behavior of kamon-akka-http.

The changes can be summed up as follows:

Change the package imports to org.apache.pekko.
Change configuration keys from akka to pekko.
Rewrite deprecated constructs

All tests are green.

This builds on top of #1264

@pjfanning
Copy link
Contributor

@DieBauer Pekko HTTP 1.0.0 should be out within the week. Pekko Connectors Kafka (alpakka-kafka equivalent) should be out this week too - if you are interested in adding support for that too.

@pjfanning
Copy link
Contributor

pjfanning commented Aug 2, 2023 •
edited
Loading

@DieBauer Pekko HTTP 1.0.0 and Pekko Connectors Kafka 1.0.0 are released

@DieBauer DieBauer marked this pull request as ready for review August 7, 2023 08:37
@ivantopo
Copy link
Contributor

ivantopo commented Aug 9, 2023

@DieBauer could you please rebase this PR on master now that the pekko instrumentation is merged? thanks!

@DieBauer
Copy link
Contributor Author

DieBauer commented Aug 9, 2023

Done!

@ivantopo ivantopo merged commit 14cba52 into kamon-io:master Aug 10, 2023
1 check passed
@ivantopo
Copy link
Contributor

Thank you very much for all the work here @DieBauer! I'll release this as Kamon Telemetry 2.7 at some point before Sunday since I have one more bit of instrumentation I want to include in that release. Great job!

@DieBauer DieBauer deleted the pekko-http branch August 10, 2023 06:48
@drenizg
Copy link

drenizg commented Aug 18, 2023

Hi everyone, nice job! Is there any update on when is this being released?

hughsimpson pushed a commit to hughsimpson/Kamon that referenced this pull request Aug 22, 2023
@DieBauer @hughsimpson
Add kamon-pekko-http (kamon-io#1285)
c92f87c 
* Add kamon-pekko-http module for Apache Pekko HTTP support

* Rework deprecated methods

* Remove pekko-http2-support module

see apache/pekko-http#52

* Remove Akka 10.1 references

* Set pekko-http 1.0.0-RC2

* Use Pekko HTTP release version
@mebigfatguy
Copy link

Sorry for being such a scala noob, but trying to build the 2.13 version of kamon-pekko, kamon-pekko-http

and get

[info] loading project definition from /home/acme/dev/external/Kamon/instrumentation/kamon-pekko/project
/home/acme/dev/external/Kamon/instrumentation/kamon-pekko/build.sbt:4: error: not found: value scala_2.12_version
crossScalaVersions := Seq(scala_2.12_version, scala_2.13_version)
^
/home/acme/dev/external/Kamon/instrumentation/kamon-pekko/build.sbt:4: error: not found: value scala_2.13_version
crossScalaVersions := Seq(scala_2.12_version, scala_2.13_version)

could someone point me in the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DieBauer @pjfanning @ivantopo @drenizg @mebigfatguy