Add ZIO2 context propagation #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m50d
approved these changes
Jan 10, 2024
Comment on lines
49
to
57
| override def onSuspend[E, A_](fiber: Fiber.Runtime[E, A_])(implicit unsafe: Unsafe): Unit = { | ||
| val pctx = Kamon.currentContext() | ||
| fiber.asInstanceOf[HasContext].setContext(pctx) | ||
| } | ||
|
|
||
| override def onResume[E, A_](fiber: Fiber.Runtime[E, A_])(implicit unsafe: Unsafe): Unit = { | ||
| val ctx = fiber.asInstanceOf[HasContext].context | ||
| Kamon.storeContext(ctx) | ||
| } |
There was a problem hiding this comment.
Are these the right way around? That looks opposite from what I'd expect but IDK.
There was a problem hiding this comment.
on suspend you're setting the context of the fiber that you had back to the fiber itself where you were executing it.
onResume your taking the fiber from the pool that you are resuming and applying context to the current session. I am probably saying that wrong.
|
@ivantopo would love for you to take a look |
hughsimpson
approved these changes
Mar 1, 2024
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the CE3 tests, but made them work in ZIO style.