-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kamon http4s #1319
Merged
Merged
Add kamon http4s #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad4d9bd
to
78c62c6
Compare
78c62c6
to
227b964
Compare
there's a flaky test, potentially needs some investigation so it doesn't become a problem for the whole release process Also the packaging is problematic, this will need a bit more work |
I've addressed the flakiness as best as I could and changed the approach on structuring the modules + publishing, ready to be reviewed! |
hughsimpson
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves kamon-http4s here.
Noteable events:
- We have left a common configuration because we identified common code, but haven't changed anything from the original source. My suggestion is we release as is and then we can refactor the common code to avoid investigation of what changed for any weird regressions .We have added theY-partial-unification
flag to the common compilation settings of 2.12, it seemed easier, we can move to http4s only if deemed necessaryWe followed the kamon-akka as a template for the setup, but we have not changed the original kamon-http4s code, only the sbt setupPlease let us know if we missed anything, I've tested +test, +publishLocal in the kamon-http4s project
Credits and special thanks
This PR is co-authored with @irodotos7 and our time was funded by @vaslabs-ltd