Added and applied scalafmt #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to comment here besides our chat so yes! Happy to see the entire repo become consistent 😄 |
|
Maybe also add |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured maybe it was time to format everything 😅
I've tried to pick a set of configurations that best reflect the predominant coding style across the project, although there is (inevitably!) a lot of inconsistency in the existing codebase.
As long as this pr is merged by a standard merge (rather than a squash) we should ignore the result of the initial scalafmtAll in git blame, because of the inclusion of
.git-blame-ignore-revswith a reference to the relevant commit.I've also added a linting check to the CI jobs to
catch out the unwarypreserve this beautiful new world.Over to you, @ivantopo 😄