Add Apache HttpClient 4.x instrumentation #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hughsimpson could you please review this if possible? |
PrajeenRG
force-pushed
the
apache-httpclient
branch
from
88db1e7
to
3bbb3f3
Compare
|
Look at me getting pings to review like a proper OSS maintainer 😂 tell you what @PrajeenRG I'll check this out tomorrow if you do me a solid and give a once-over on the lib bumps I've proposed here |
|
Looks like a proper OSS maintainer to me at least 😁🤦♂️. Your changes for version bumps looks good to me, doesn't seem like it will cause some havoc here. |
|
@hughsimpson are you good with the changes? |
hughsimpson
approved these changes
Mar 12, 2024
|
@PrajeenRG LGTM! Sorry about the slight delay there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains instrumentation code compatible with Apache HttpClient 4.0 onwards.
All the tests written to confirm the tracing are passing.