add support for optimistic alignment to PeriodSnapshot.accumulator #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @dpsoft. Do you have any plans to merge this PR and release it? I've made a private fork, so I'd like to remove it and use the official Kamon. Best, |
perenecabuto
force-pushed
the
feature/add-support-to-optimistic-alignment-to-accumulator
branch
from
bc33b1d
to
6fc3663
Compare
perenecabuto
force-pushed
the
feature/add-support-to-optimistic-alignment-to-accumulator
branch
from
6fc3663
to
e62848a
Compare
perenecabuto
force-pushed
the
feature/add-support-to-optimistic-alignment-to-accumulator
branch
from
e62848a
to
8b54aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support to PeriodSnapshot.Accumulator to do not align tickers when kamon.metric.optimistic-tick-alignment is disabled.
Motivation:
Here in my team we use Kamon in many projects and we use accumulators to have different metric ticker times.
As we have very heavy metrics load sent to our metrics DB and our API server has many units,
it uses an entropy strategy to do not send all the messages at the same time from all the units.
So we disable kamon.metric.optimistic-tick-alignment and start Kamon with a random delay and expect that the accumulators respect this policy.