Update actions/checkout action to v6.0.1 #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mensfeld
added a commit
to karafka/karafka-rdkafka
that referenced
this pull request
Dec 11, 2025
…ention (#319) * Update actions/checkout action to v6.0.1 (karafka#757) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Disable RSpec monkey patching (karafka#620) (karafka#758) Add config.disable_monkey_patching! to spec_helper.rb and update all spec files to use explicit RSpec.describe instead of the monkey-patched describe. * Extract timeout defaults to Rdkafka::Defaults module (karafka#759) * Extract timeout defaults to Rdkafka::Defaults module Add a centralized Defaults module containing all timeout constants, making them discoverable and allowing users to understand/override them. This addresses issue #310 where default timeouts (200-250ms) are insufficient for operations with remote Kafka clusters. Changes: - Create lib/rdkafka/defaults.rb with 17 timeout/config constants - All time-related values are now in milliseconds for consistency - Update all methods to reference Defaults constants instead of literals - Add timeout_ms parameter to Consumer#each for configurability - Change AbstractHandle#wait parameter from max_wait_timeout (seconds) to max_wait_timeout_ms (milliseconds) - Add spec/lib/rdkafka/defaults_spec.rb with tests Breaking change: AbstractHandle#wait now uses max_wait_timeout_ms instead of max_wait_timeout. * Extract PARTITIONS_COUNT_CACHE_TTL_MS to Defaults module - Add PARTITIONS_COUNT_CACHE_TTL_MS (30000ms) to Rdkafka::Defaults - Change PartitionsCountCache constructor from `ttl` (seconds) to `ttl_ms` (milliseconds) - Update specs to use milliseconds for TTL values - Update CHANGELOG with breaking change This is a breaking change for direct users of PartitionsCountCache. * Update yard-lint to 1.3.0 and fix lint offenses (karafka#760) * Update yard-lint to 1.3.0 and fix lint offenses - Update yard-lint gem constraint to ~> 1.3.0 - Run yard-lint --update to add new validators to .yard-lint.yml - Fix BlankLineBeforeDefinition offenses in bindings.rb - Fix EmptyCommentLine offenses in acl_binding_result.rb and topic_partition_list.rb - Add missing @param documentation to private initialize methods - Add documentation for callback methods and result classes - Fix InvalidTagType and type syntax in headers.rb and oauth.rb - Fix RedundantParamDescription offenses in admin.rb and consumer.rb - Exclude bindings.rb from UndocumentedObjects check (internal FFI file) * Fix macOS ARM64 test failures by using explicit IPv4 address Change bootstrap.servers from localhost:9092 to 127.0.0.1:9092 in spec_helper.rb to avoid IPv6 resolution issues on macOS. On macOS-14 (Sonoma), localhost can resolve to IPv6 (::1) first, but Kafka is configured to listen only on 127.0.0.1:9092 (IPv4). This causes "Connection refused" errors when librdkafka tries to connect to [::1]:9092. Using explicit IPv4 address matches the Kafka configuration in both docker-compose.yml and ci_macos_arm64.yml workflows. * Update confluentinc/cp-kafka Docker tag to v8.1.1 (karafka#761) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix RSpec describe syntax in kept spec files Upstream disabled RSpec monkey patching, so describe -> RSpec.describe * Fix PartitionsCountCache to use ttl_ms parameter consistently The cache TTL is now in milliseconds to align with the _ms convention. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v6.0.0->v6.0.1Release Notes
actions/checkout (actions/checkout)
v6.0.1Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.