Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Black new widgets#738

Open
7sco wants to merge 3 commits intokarimknaebel:masterfrom
7sco:black-new-widgets
Open

Black new widgets#738
7sco wants to merge 3 commits intokarimknaebel:masterfrom
7sco:black-new-widgets

Conversation

@7sco
Copy link
Contributor

@7sco 7sco commented Aug 23, 2019

Add two new widgets for user with amoled screens

Black:
Screenshot_20191104-103617_Nova Launcher

Classic Black:

tempFileForShare_20191104-103606

@GeoZac
Copy link
Contributor

GeoZac commented Aug 24, 2019

Wouldn't be easier setting a tint to the bg drawable?

@7sco
Copy link
Contributor Author

7sco commented Aug 24, 2019

Wouldn't be easier setting a tint to the bg drawable?

Yes that is posible, but since the app minSdk is 16 and adding a tint will only work for apps >21, also the card_black file is different from card file

@paolovalerdi
Copy link
Contributor

Wouldn't be easier setting a tint to the bg drawable?

Yes that is posible, but since the app minSdk is 16 and adding a tint will only work for apps >21, also the card_black file is different from card file

Isn't there and "compat" method?

@7sco
Copy link
Contributor Author

7sco commented Sep 3, 2019

Wouldn't be easier setting a tint to the bg drawable?

Yes that is posible, but since the app minSdk is 16 and adding a tint will only work for apps >21, also the card_black file is different from card file

Isn't there and "compat" method?

@paolovalerdi There Is but it seems that since we are using RemoteViews it is more complex, I believe that this approach is cleaner and it works with older android versions

@7sco
Copy link
Contributor Author

7sco commented Nov 2, 2019

@GeoZac and @paolovalerdi should this pr and other pending prs be closed, haven't got any update ??

@GeoZac
Copy link
Contributor

GeoZac commented Nov 3, 2019

Maybe @kabouzeid or @arkon can comment on this.

@karimknaebel
Copy link
Owner

@7sco Sorry for the late reply. I’m not very active these days. Could you upload a screenshot of this and the widget before?

@7sco
Copy link
Contributor Author

7sco commented Nov 4, 2019

@kabouzeid added screenshots

@karimknaebel
Copy link
Owner

Wait, what’s the difference between the two?

@7sco
Copy link
Contributor Author

7sco commented Nov 8, 2019

Wait, what’s the difference between the two?

@kabouzeid The second one the image height is bigger than the info card

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants