Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users may not have control over the max watches limit of the
recommended_watcher. In this case, it is desirable to fallback to thePollWatcherimplementation which is x-platform as far as I can tell and shouldn't experience the same restriction.To check if the watcher limit has been reached, we create a
NamedTempFileusingtempfileand check the result ofwatcher.watchon therecommended_watcher.I've also removed some unwraps which were causing problems. Some are replaced with match blocks, others with bindings. I can't see any immediate problems from this, but it might be worth checking it out.
The checking code might be better off in a separate function which returns a
Box<dyn Watcher>so can do that if you'd prefer.