Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

fix(launcher) workers fail to launch after tunnel #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aminer-looker
Copy link

In some environments, the process which establishes the tunnel can
report that it is operational significantly before the tunnel is
actually established. This will cause subsequent calls to create a
worker to fail.

This change waits a short interval after the tunnel process has
reported itself started to allow it to actually finish establishing
the tunnel before attempting to create any workers.

Fixes #42

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@aminer-looker aminer-looker force-pushed the fix-tunnel-takes-too-long-to-establish branch from 824d524 to 4cf2caa Compare October 20, 2015 17:06
In some environments, the process which establishes the tunnel can
report that it is operational significantly before the tunnel is
actually established. This will cause subsequent calls to create a
worker to fail.

This change waits a short interval after the tunnel process has
reported itself started to allow it to actually finish establishing
the tunnel before attempting to create any workers.

Fixes karma-runner#42
@aminer-looker
Copy link
Author

My company, Looker Data Services, Inc., has signed the CLA.

@dignifiedquire
Copy link
Member

I'm not a big fan of introducing a fixed delay for everyone. Would it be possible to test immediately if the connection is working, and if not do a check every second for 5 seconds or something like that until it becomes available?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants